Fixing race condition in channel test #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
force-pushed
the
fixing_post_3104
branch
2 times, most recently
from
9584dd5
to
7179bea
Compare
… execution) - this was exposed by the recent patch fixing direct execution (#3104) - flyby: don't run channel_2916 as a distributed test
hkaiser
force-pushed
the
fixing_post_3104
branch
from
7179bea
to
a3b54b0
Compare
sithhell
reviewed
Jan 20, 2018
| @@ -66,7 +66,7 @@ set(async_callback_non_deduced_context_PARAMETERS THREADS_PER_LOCALITY 4) | |||
| set(broadcast_unwrap_future_2885_PARAMETERS LOCALITIES 2 THREADS_PER_LOCALITY 4) | |||
| set(broadcast_wait_for_2822_PARAMETERS LOCALITIES 2 THREADS_PER_LOCALITY 4) | |||
| set(channel_2916_FLAGS DEPENDENCIES iostreams_component) | |||
| set(channel_2916_PARAMETERS LOCALITIES 2 THREADS_PER_LOCALITY 4) | |||
| set(channel_2916_PARAMETERS THREADS_PER_LOCALITY 4) | |||
There was a problem hiding this comment.
why did you remove distributed testing here?
There was a problem hiding this comment.
Because the test itself does not do any distributed work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Any background context you want to provide?