Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phantomjs2: set QT_QPA_PLATFORM to allow use in daemons #34069

Merged
merged 1 commit into from Jan 21, 2018

Conversation

lukeadams
Copy link
Contributor

resolves issues with Grafana alert image attachments

Suggested in ariya/phantomjs#15217 (comment)

Grafana logs showed this:

Jan 19 22:20:42 elastomer grafana-server[3418]: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-grafana'
Jan 19 22:20:42 elastomer grafana-server[3418]: qt.qpa.screen: QXcbConnection: Could not connect to display
Jan 19 22:20:42 elastomer grafana-server[3418]: Could not connect to any X display.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

resolves issues with Grafana email attachments

Suggested in ariya/phantomjs#15217 (comment)
@lukeadams
Copy link
Contributor Author

lukeadams commented Jan 20, 2018

Better is to wait for phantomjs v2.1.3 which includes internal fix ariya/phantomjs@db349b4

I'll leave this open since I have no idea how long until 2.1.3 is released

if anybody hits the issue though the commit in this PR can be cherry picked

@lukeadams lukeadams closed this Jan 20, 2018
@lukeadams lukeadams reopened this Jan 20, 2018
@grahamc
Copy link
Member

grahamc commented Jan 20, 2018

@GrahamcOfBorg build phantomjs2

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1
shrinking /nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1/bin/.phantomjs-wrapped
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1/bin 
patching script interpreter paths in /nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1
checking for references to /tmp/nix-build-phantomjs-2.1.1.drv-0 in /nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/bpjpk19hzfhxx1zqahiah0nldr1v75m7-phantomjs-2.1.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1
shrinking /nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1/bin/.phantomjs-wrapped
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1/bin
patching script interpreter paths in /nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1
checking for references to /build in /nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1...
postPatchMkspecs
postPatchMkspecs
/nix/store/m40gy35d88nz4s9cknfnqpkzsvdbf93y-phantomjs-2.1.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

cannot build derivation '/nix/store/3bz85dj54hys06ls0fs97qkf834wydzy-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/skgxashafxad1cl9gfvqrbazv5m2k33b-qtsvg-5.10.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/rxlvjn7fqh223264wwyirlpldygin11v-qtxmlpatterns-5.10.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/px4nnajjnmzhrzgihq2gxjklf7vfd6h0-qtdeclarative-5.10.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/nnz50r45pcl2qkjwnln6mh2pwwh8f8zh-qtmultimedia-5.10.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5vzsv5dw9bvgcyysc3b3ckpl0w8asrwg-qtsensors-5.10.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/29iivkf5q5a0iivf6d969224bqgjf1q1-qtlocation-5.10.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8df9j7znk1dgzza1hpvh729rqkzbjx50-qtwebkit-5.9.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/d9j10a178v2xfz80s2qiwc3skr3d70j3-phantomjs-2.1.1.drv': 3 dependencies couldn't be built
error: build of '/nix/store/d9j10a178v2xfz80s2qiwc3skr3d70j3-phantomjs-2.1.1.drv' failed

@lukeadams
Copy link
Contributor Author

@Mic92 Mic92 merged commit 9858950 into NixOS:master Jan 21, 2018
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018

Your fix can be removed then after the next upgrade of phantomjs.

@lukeadams lukeadams deleted the phantomjs-headless-fix branch May 26, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants