Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 57.0.4 -> 58.0, firefox-esr: 52.5.3esr -> 52.6.0esr #34073

Merged
merged 2 commits into from Jan 23, 2018
Merged

firefox-bin: 57.0.4 -> 58.0, firefox-esr: 52.5.3esr -> 52.6.0esr #34073

merged 2 commits into from Jan 23, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 20, 2018

Motivation for this change

Release notes are not updated yet:
https://www.mozilla.org/en-US/firefox/58.0/releasenotes/
https://www.mozilla.org/en-US/firefox/52.6.0/releasenotes/

Notes on the source package:

I could not build the source package. It results in error: failed to acquire jobserver token.

This may related to the following issues:

Using rustc 1.23.0 doesn't help.

Full message:

[nix-shell:~/tmp/firefox-58.0]$ ./mach build
 0:00.48 /nix/store/pi3cnkd4v5d4ncgg1c4m3avmvdin953s-gnumake-4.2.1/bin/make -f client.mk -s
 0:01.50 Adding client.mk options from /home/t/tmp/firefox-58.0/mozconfig:
 0:01.50     MOZ_OBJDIR=/home/t/tmp/firefox-58.0/obj-x86_64-pc-linux-gnu
 0:01.50     OBJDIR=/home/t/tmp/firefox-58.0/obj-x86_64-pc-linux-gnu
 0:01.50     FOUND_MOZCONFIG=/home/t/tmp/firefox-58.0/mozconfig
 0:01.76 Elapsed: 0.00s; From dist/branding: Kept 4 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.77 Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.77 Elapsed: 0.00s; From dist/xpi-stage: Kept 3 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.78 Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.81 Elapsed: 0.03s; From _tests: Kept 453 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.83 Elapsed: 0.06s; From dist/idl: Kept 1006 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:01.94 Elapsed: 0.16s; From dist/bin: Kept 2101 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:02.03 Elapsed: 0.26s; From dist/include: Kept 4908 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:02.05 buildid.h
 0:02.13 source-repo.h
 0:02.24 backend.mk:2263: warning: overriding recipe for target '../dist/system_wrappers/pixman.h'
 0:02.24 backend.mk:1353: warning: ignoring old recipe for target '../dist/system_wrappers/pixman.h'
 0:02.26 backend.mk:2263: warning: overriding recipe for target '../dist/system_wrappers/pixman.h'
 0:02.26 backend.mk:1353: warning: ignoring old recipe for target '../dist/system_wrappers/pixman.h'
 0:02.27 application.ini
 0:02.37 application.ini.h
 0:02.47 Elapsed: 0.06s; From ../../dist/idl: Kept 1006 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:02.67 force-cargo-library-build
 0:03.35    Compiling slab v0.3.0
 0:03.76 error: failed to acquire jobserver token
 0:03.76 
 0:03.76 Caused by:
 0:03.76   Resource temporarily unavailable (os error 11)
 0:03.76 make[4]: *** [/home/t/tmp/firefox-58.0/config/rules.mk:953: force-cargo-library-build] Error 101
 0:03.76 make[3]: *** [/home/t/tmp/firefox-58.0/config/recurse.mk:73: toolkit/library/rust/target] Error 2
 0:03.76 make[3]: *** Waiting for unfinished jobs....
 0:03.93 libnetwerk_dns_mdns_libmdns.a.desc
 0:04.32 libnetwerk_streamconv.a.desc
 0:04.42 libnetwerk_mime.a.desc
 0:04.70 libnetwerk_socket.a.desc
 0:07.56 libnetwerk_streamconv_converters.a.desc
 0:09.15 libnetwerk_cache.a.desc
 0:13.51 libnetwerk_cache2.a.desc
 0:13.58 make[2]: *** [/home/t/tmp/firefox-58.0/config/recurse.mk:33: compile] Error 2
 0:13.58 make[1]: *** [/home/t/tmp/firefox-58.0/config/rules.mk:432: default] Error 2
 0:13.58 make: *** [client.mk:274: build] Error 2
 0:13.60 0 compiler warnings present.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Jan 20, 2018

Could that have been some transient or nix-shell-specific problem? On the commit as you posted it, I got a few minutes into the build phase (so far).

vcunat
vcunat approved these changes Jan 20, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested running both briefly.

@vcunat
Copy link
Member

vcunat commented Jan 20, 2018

firefox-bin now shows a fixed-width font in the address bar, which feels a little strange. It's not too bad though; maybe it's about my config...

@taku0
Copy link
Contributor Author

taku0 commented Jan 20, 2018

@vcunat this branch does not contain updates for the source package.

@vcunat
Copy link
Member

vcunat commented Jan 20, 2018

I thought you meant firefox-esr source package.

@taku0
Copy link
Contributor Author

taku0 commented Jan 20, 2018

firefox-esr is fine. I meant firefox package.

@taku0
Copy link
Contributor Author

taku0 commented Jan 20, 2018

Firefox 58 uses a new build script mach, so updating common.nix is not trivial.

@vcunat
Copy link
Member

vcunat commented Jan 22, 2018

Still no release notes, and their web suggests installing FF 57. That seems like they don't mean 58 for general public yet.

@tokudan
Copy link
Contributor

tokudan commented Jan 23, 2018

ff58 has been released, so those parts that are not blocked due to errors could be merged now.

@vcunat vcunat merged commit 0c88f6c into NixOS:master Jan 23, 2018
vcunat added a commit that referenced this pull request Jan 23, 2018
@vcunat
Merge #34073: firefox-{bin,esr}: update
24fe57d
vcunat added a commit that referenced this pull request Jan 23, 2018
@vcunat
Merge #34073: firefox-{bin,esr}: update
c52254b 
(cherry picked from commit 24fe57d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @vcunat @tokudan @GrahamcOfBorg