Support the us package #34076
Merged
Support the us package #34076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build pythonPackages.us |
There was a problem hiding this comment.
Success for system: x86_64-linux
reading manifest file 'us.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'us.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/7yxp126iyrdg85vd9ckgi5brksk0r1g9-python2.7-us-1.0.0
There was a problem hiding this comment.
Success for system: x86_64-darwin
reading manifest file 'us.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'us.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/pm86ljqshhq7aias0p0pfk00xwzbjix4-python2.7-us-1.0.0
There was a problem hiding this comment.
Success for system: aarch64-linux
reading manifest file 'us.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'us.egg-info/SOURCES.txt'
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
/nix/store/k4h2kfgld3ykimqrhjspqc3gk7mg59cq-python2.7-us-1.0.0
zimbatm
reviewed
Jan 20, 2018
There was a problem hiding this comment.
the code is looking good!
the only issue is with the commit message. we try to follow a pattern to help us with package statistics. In that case the commit message would be pythonPackages.us: init at 1.0.0 (EDIT: fixed during sqash-merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)