nixos/ckb: Add option to restrict access to the devices to a particu... #34064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierdavis
suggested changes
Jan 22, 2018
nixos/modules/hardware/ckb.nix
Outdated
| @@ -10,6 +10,15 @@ in | |||
| options.hardware.ckb = { | |||
| enable = mkEnableOption "the Corsair keyboard/mouse driver"; | |||
|
|
|||
| gid = mkOption { | |||
| type = types.nullOr types.str; | |||
There was a problem hiding this comment.
It appears that ckb-daemon only accepts actual GIDs and not group names, so please could we change the type of this option to types.int and update the example to reflect this?
|
You're right, I changed that. Thanks for the fast feedback ! |
kierdavis
approved these changes
Jan 23, 2018
|
merged in 99a8c45 |
Mic92
pushed a commit
that referenced
this pull request
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ar group
Motivation for this change
By default, the ckb daemon allows acces to its controlling socket to any process (chmod 666), which is kinda crazy. This PR allows to restrict access to a unix group.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)