openmpi: 1.10.7->3.0.0, add markuskowa as maintainer #34065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build |
There was a problem hiding this comment.
Failure for system: aarch64-linux
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.
There was a problem hiding this comment.
Failure for system: x86_64-linux
error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.
|
@grahamc How can I figure out what causes the build problem? The derivation builds on my local NixOS. |
lsix
reviewed
Jan 25, 2018
| meta = { | ||
| homepage = http://www.open-mpi.org/; | ||
| description = "Open source MPI-2 implementation"; | ||
| longDescription = "The Open MPI Project is an open source MPI-2 implementation that is developed and maintained by a consortium of academic, research, and industry partners. Open MPI is therefore able to combine the expertise, technologies, and resources from all across the High Performance Computing community in order to build the best MPI library available. Open MPI offers advantages for system and software vendors, application developers and computer science researchers."; | ||
| maintainers = [ ]; | ||
| maintainers = with maintainers; [ markuskowa ]; |
There was a problem hiding this comment.
It should be with stdenv.lib.maintainers I think.
This would be fine if in line 48 you had meta = with stdenv.lib; { (which is often done since stdenv.lib is used to access licenses and maintainers). Since no license is given here (maybe there should), you can just fix the with in line 52.
markuskowa
changed the title
markuskowa
force-pushed
the
openmpi3-pr
branch
from
8d6b322
to
b8707e3
Compare
|
Thanks for the feedback! I did some cleanup of the commits and the PR message (and title). |
* add license * update description * add markuskowa as maintainer
markuskowa
force-pushed
the
openmpi3-pr
branch
from
6c8caab
to
aa83877
Compare
|
@GrahamcOfBorg build openmpi |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
@GrahamcOfBorg build python3.pkgs.h5py-mpi |
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
I do not really understand why the build fails. Is this a hydra related problem? I can build everything locally. |
|
It seems it just took too long.
…On Sat, Feb 10, 2018 at 4:07 PM markuskowa ***@***.***> wrote:
building of ‘/nix/store/5hj3cr14s8cg0xy54azaaa79sbssdpdb-python3.6-mpi4py-3.0.0.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/lgmg9xkd4majq0kv52gh89jj52wj0qv0-python3.6-h5py-2.7.1.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/lgmg9xkd4majq0kv52gh89jj52wj0qv0-python3.6-h5py-2.7.1.drv’ failed
I do not really understand why the build fails. Is this a hydra related
problem? I can build everything locally.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34065 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrCFkMJ5g-F3FedmoM6ykj9rDSEtUks5tTgUrgaJpZM4RlN-g>
.
|
|
Sandboxed build seems to hang for me (no CPU is consumed): |
test_spawn.py fails when build with openmpi-3.0.0 in a sandboxed environment.
|
Thanks the for input. I could identify the problem: one particular test in mpi4py (test_spawn.py) fails, when built in a sandboxed environment. This failure is caused by openmpi not being able to communicate with its processes resulting in a hanging build process (this is what caused the hydra eval to time out). This test is only executed for openmpi version 3.0.0 or greater even though the spawn feature is already available in all previous stable openmpi versions. I added a patch that turns off this specific test. This might not be best practice but it solves the problem for now. Since all unit tests still run with sandbox disabled the package could still be considered functional (?). |
|
@markuskowa can you open an issue upstream? |
|
I can give it a try although I am not sure how to reproduce the problem in a non-nixos environment. The problem seems to be the sandbox build environment, which openmpi collides with. I'm not sure that openmpi was ever designed to run in a such an restricted environment. |
|
I would expect openmpi to time out if it can't connect to whatever it is connecting. |
|
Ah ok, yes the missing time out is a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to the latest stable version. Added myself as maintainer.
Other changes:
withlibnlandzlibsupportdoCheck=true)Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"Some test fail due to broken tensorflow derivations (Tensorflow build fails on master #31492)
./result/bin/)