nixos/less configure less with module #34381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
commented
Jan 29, 2018
nixos/modules/programs/less.nix
Outdated
| "${pkgs.less}/bin/lesskey -o $out $src"; | ||
|
|
||
| lessPipe = pkgs.writeScriptBin "lesspipe.sh" '' | ||
| #! /bin/sh |
There was a problem hiding this comment.
Should I change it to #!${stdenv.shell}?
There was a problem hiding this comment.
I wonder if lesspipe would be the better default here. We already package it in nixpkgs.
There was a problem hiding this comment.
Yup, that's a good idea. It's (almost) always better to use something well maintained than to hack a script together yourself.
Rather than a custom script the less config now uses the lesspipe package config by default.
|
Thanks. Module looks good to me with good examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Because less is configured not directly with a plaintext file but the config file requires translation to a binary file I thought this is the perfect use case for a nixos module.
Not only can less be configured declaratively now, but I added the convenience that less by default now extracts (xz, gzip, bz2) compressed files transparently before reading.
I think everything possible in the real configuration can be done with the nix language now - therefore there is no need for an option like "extraConfig".
Things done
Added a module to configure less with. Extracts compressed files by default before opening them.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)