backport borgbackup 1.1.4 for release-17.09 #34368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build borgbackup |
There was a problem hiding this comment.
Failure on aarch64-linux (full log)
Partial log (click to expand)
error: while evaluating the attribute 'propagatedBuildInputs' of the derivation 'borgbackup-1.1.4' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'nativeBuildInputs' of the derivation 'python3.6-Cython-0.26.1' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'buildInputs' of the derivation 'python3.6-numpy-1.13.3' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'makeFlags' of the derivation 'openblas-0.2.20' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating 'mapAttrsToList' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/lib/attrsets.nix:223:23, called from /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/libraries/science/math/openblas/default.nix:103:8:
unsupported system: aarch64-linux
There was a problem hiding this comment.
Success on x86_64-darwin (full log)
Partial log (click to expand)
Build finished. The manual pages are in _build/man.
make: Leaving directory '/private/tmp/nix-build-borgbackup-1.1.4.drv-0/borgbackup-1.1.4/docs'
post-installation fixup
gzipping man pages under /nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4/share/man/
stripping (with flags -S) in /nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4/lib /nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4/bin
patching script interpreter paths in /nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4
wrapping `/nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4/bin/borg'...
wrapping `/nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4/bin/borgfs'...
/nix/store/s3j0yb4aa27zk8cgclc6b93mcsl2pbha-borgbackup-1.1.4
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/lib/python3.6/site-packages/borg/crypto/low_level.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/lib/python3.6/site-packages/borg/platform/linux.cpython-36m-x86_64-linux-gnu.so
shrinking /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/lib/python3.6/site-packages/borg/platform/posix.cpython-36m-x86_64-linux-gnu.so
gzipping man pages under /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/share/man/
stripping (with flags -S) in /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/lib /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/bin
patching script interpreter paths in /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4
checking for references to /tmp/nix-build-borgbackup-1.1.4.drv-0 in /nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4...
wrapping `/nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/bin/borg'...
wrapping `/nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4/bin/borgfs'...
/nix/store/1p63bnppdnq60080dncbnigqhzq6h5vc-borgbackup-1.1.4
|
Please use |
flokli
force-pushed
the
borgbackup-1.1.4
branch
from
11fedf0
to
7b6df3b
Compare
flokli
force-pushed
the
borgbackup-1.1.4
branch
from
7b6df3b
to
39f8b75
Compare
|
Good point, thanks! Re-cherry-picked the The borgbackup commits are a bit trickier, as the changes are a combination from multiple commits (borgbackup itself), or the referenced commit did more (remove nckx from more than borgbackup). What do you want me to do there? Additionally, I tried building borgbackup on the aarch64 machine, but this fails at |
|
I have now also added a nixos test for it: #33315 |
We had problems to get borg's own test suite running. This test is intended to perform a quick smoke test to see whether we have missed not any important dependency necessary to create backups with borg. tested with: $ nix-build nixos/release.nix -A tests.borgbackup.x86_64-linux (cherry picked from commit 8a5f77f)
|
@Mic92 right, thanks! Cherry-picked and tested your test, feel free to merge :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #33053
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)