Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules/nvidia-optimus: fix module blacklisting #34384

Merged
merged 1 commit into from Feb 10, 2018
Merged

modules/nvidia-optimus: fix module blacklisting #34384

merged 1 commit into from Feb 10, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2018

Motivation for this change

Currently if hardware.nvidiaOptimus.disable = true blacklisting doesn't work. Blacklist additional module, so no nvidia modules are loaded. Inspired by 4111710#diff-9e16548d809be859135402f495fc2ad7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 2cab78b into NixOS:master Feb 10, 2018
@ghost
Copy link
Author

ghost commented Feb 10, 2018

@Mic92 Thank you!

@ghost ghost deleted the nvidia-optimus branch February 10, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @FRidh @GrahamcOfBorg