Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: Fix Darwin build #34373

Merged
merged 1 commit into from Jan 29, 2018
Merged

glib: Fix Darwin build #34373

merged 1 commit into from Jan 29, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jan 29, 2018 •
edited

Motivation for this change

Fix the failure caused in #34198 by a suggested change of mine. @vcunat reported in #34198 (comment).

Things done

Restored how flags were before so its bound to work.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
glibc: Fix Darwin build
82ebace 
Fix the failure caused in NixOS#34198 by a suggested change of mine. @vcunat
reported in [1].

[1]: NixOS#34198 (comment)
@vcunat vcunat merged commit 82ebace into NixOS:staging Jan 29, 2018
vcunat added a commit that referenced this pull request Jan 29, 2018
@vcunat
Merge #34373: add comment to the first-parent commit
a073e7f 
The PR was done in parallel.
@vcunat
Copy link
Member

vcunat commented Jan 29, 2018 •
edited

Funny title :-) I pushed an almost identical fix around the same time.

@Ericson2314 Ericson2314 deleted the glib-darwin branch January 29, 2018 22:57
@Ericson2314
Copy link
Member Author

Yeah sorry I didn't do this right as soon as you reported it, I was responding from my phone.

@Ericson2314 Ericson2314 changed the title glibc: Fix Darwin build glib: Fix Darwin build Sep 11, 2018
@Ericson2314
Copy link
Member Author

Oh, I just saw the title problem :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @vcunat @GrahamcOfBorg