Add ruby lang version for each jruby download #10
Conversation
| </tr> | ||
| <tr> | ||
| <td><a href='/files/downloads/9.0.0.0.pre1/index.html'>9.0.0.0.pre1</a></td> | ||
| <td>1.8 or 1.9</td> |
There was a problem hiding this comment.
9.0 wasn't 1.8/1.9 compatible - believe it started with 2.2 compat
| </tr> | ||
| <tr> | ||
| <td><a href='/files/downloads/1.7.9/index.html'>1.7.9</a></td> | ||
| <td>1.8 or 1.9</td> |
There was a problem hiding this comment.
while its better than previous - its a bit unclear due how 1.8/1.9 were versioned.
maybe it should say 1.8.7/1.9.3 compatible - starting 1.7.0 it was 1.9.3 (while 1.6.8 was 1.9.2 - not sure)
| </tr> | ||
| <tr> | ||
| <td><a href='/files/downloads/1.7.0.RC1/index.html'>1.7.0.RC1</a></td> | ||
| <td>1.8 or 1.9</td> |
There was a problem hiding this comment.
I would say the table would be easier to the eye if the rows with the same value are combined with the rowspan attribute.
| <td></td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href='/files/downloads/1.5.0/index.html'>1.5.0</a></td> |
There was a problem hiding this comment.
I seem to remember 1.5 being the first to add MRI 1.9 compatibility in a serious way. I could be mistaken, though.
| <tbody> | ||
| <tr> | ||
| <td><a href='/files/downloads/0.9.0/index.html'>0.9.0</a></td> | ||
| <td></td> |
There was a problem hiding this comment.
The lack of information here and subsequent rows should be addressed somehow—by having a separate table with no compatibility information, by completing the trade arch, or by some other means.
|
Thanks for the feedback everyone - I'm happy to make these changes and resubmit, but I need some help first. I'm currently unable to build and run the server locally. I followed the directions on the README.md and even made a Dockerfile in a branch on my forked version to try and create a reproducible environment. Here are my findings:
After this error I just tried running the server:
This encounters another exception listed below: I tried accessing the site with: http://localhost:9292/ but got: Any thoughts? I'll keep digging into the rakefile and jekyll when I get a chance. |
This is an addition that I would like added to the downloads page. I had a brief conversation on the IRC chat that precipitated this change. I've copied a snippet of that conversation here:
I don't have any ruby lang version to add for jruby versions 0.9 - 1.6. Since they're older versions maybe that's ok.