Skip to content

Clang fixes #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2018
Merged

Clang fixes #1710

merged 5 commits into from
Feb 3, 2018

Conversation

ts826848
Copy link
Contributor

@ts826848 ts826848 commented Feb 3, 2018

No description provided.

First Clang error was that the declared typename shadows that of the
containing class. If the typename is changed, continuous_trajectory_test
fails to compile, due to access of the private variable degree_, even
though it's supposedly a friend of ContinousTrajectory. Changing the
friend class declaration to

    friend class TestableContinuousTrajectory<Frame>;

also doesn't work, with Clang complaining that this is a specialization
of a non-template class. Adding a forward declaration of
TestableContinuousTrajectory allows the code to compile.
Unqualified lookup into dependent bases of class templates is a
Microsoft extension. Clang 5.0 "helpfully" just complained that the
members in question were undeclared identifiers, while clang-cl provided
the extra info needed to solve the problem.
Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miraculously, MSVC is happy too. Thanks for the quick fix!

@eggrobin eggrobin added the LGTM label Feb 3, 2018
@eggrobin eggrobin merged commit a072b4e into mockingbirdnest:master Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants