Add new package "ncpamixer" #34564
Merged
Add new package "ncpamixer" #34564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Feb 4, 2018
| make PREFIX=$out | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Will you be the maintainer of this expression?
|
@GrahamcOfBorg build ncpamixer |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
FRidh
requested changes
Feb 4, 2018
andir
reviewed
Feb 5, 2018
| nativeBuildInputs = [ cmake pkgconfig ]; | ||
|
|
||
| configurePhase = '' | ||
| make PREFIX=$out |
There was a problem hiding this comment.
While this works I think the proper approach would be:
--- a/pkgs/applications/audio/ncpamixer/default.nix
+++ b/pkgs/applications/audio/ncpamixer/default.nix
@@ -16,7 +16,11 @@ stdenv.mkDerivation rec {
nativeBuildInputs = [ cmake pkgconfig ];
configurePhase = ''
- make PREFIX=$out
+ make PREFIX=$out build/Makefile
+ '';
+
+ buildPhase = ''
+ make build
'';
meta = with stdenv.lib; {Otherwise you are building the project in the configure phase.
Stekke
force-pushed
the
master
branch
2 times, most recently
from
f50423c
to
38b5214
Compare
|
I fixed the commit message and applied andir patch. |
|
@StijnDW yes, you can use a separate commit for that but as part of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The only package I know of that has user a user friendly way to adjust pulse audio volume from a command line interface.
It works the same way as alsamixer but mimics the user interface from pavucontrol.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)