Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/emacs: set VISUAL along with EDITOR #34570

Closed
wants to merge 1 commit into from
Closed

nixos/emacs: set VISUAL along with EDITOR #34570

wants to merge 1 commit into from

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 3, 2018 •
edited

Motivation for this change

Fix #34467

Things done

cc @DamienCassou @rvl

@rvl rvl mentioned this pull request Feb 4, 2018
Closed
@rvl
Copy link
Contributor

rvl commented Feb 4, 2018

Hi @rnhmjoj . Thanks, but this is unlikely to fix #34467 because it's using the same method to set VISUAL as is used to set EDITOR. And the reporter notes that his EDITOR variable is not set.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 4, 2018

Yeah I know, this addresses the VISUAL not being set at all part.
I don't think the emacs module has anything to do with the environment not being properly set.

@rvl
Copy link
Contributor

rvl commented Feb 6, 2018

Thanks for trying, but I don't support this change. One environment variable is sufficient. The bug reporter has fixed his zsh config now.

@rnhmjoj rnhmjoj closed this Feb 24, 2018
@rnhmjoj rnhmjoj deleted the emacs branch February 23, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @rvl @GrahamcOfBorg