gnome-shell-extension-pixel-saver: init at 1.10 #34185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Jan 23, 2018
| description = "Pixel Saver is designed to save pixel by fusing activity bar and title bar in a natural way"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ jonafato ]; | ||
| homepage = https://github.com/daedalnix/pixel-saver; |
There was a problem hiding this comment.
The URL is broken (ea → ae)
There was a problem hiding this comment.
@jtojnar Thanks, fixed.
jonafato
force-pushed
the
gnome-shell-extension-pixel-saver
branch
2 times, most recently
from
9e28cf5
to
6f8460a
Compare
|
Thanks. |
jtojnar
reviewed
Jan 24, 2018
| meta = with stdenv.lib; { | ||
| description = "Pixel Saver is designed to save pixel by fusing activity bar and title bar in a natural way"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ jonafato ]; |
There was a problem hiding this comment.
Could you add the platforms attribute? https://nixos.org/nixpkgs/manual/#idm140737317010160
There was a problem hiding this comment.
Updated to include platforms = platforms.linux;.
jonafato
force-pushed
the
gnome-shell-extension-pixel-saver
branch
from
6f8460a
to
d48e704
Compare
|
@jtojnar Thanks for the feedback here. I plan to package more extensions, so getting a couple into a good state should make the following ones easier. |
|
Thanks. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the pixel saver GNOME Shell extension
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)