Implement Rational#coerce with Complex object
#5001
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MRI * if the argument is complex with zero imaginary part, converts it to ratinal * if the argument is complex with non-zero imaginary part, converts self to complex Ref: https://github.com/ruby/ruby/blob/v2_3_0/rational.c#L1171
|
🥇 👍 ... but maybe its better to target master (9.2) with these - not sure? (unless of course there's bugs) on the other hand I am happy to handle these merges we'll need to sync up about the plan for 9.1 as it didn't merge over in a while and it won't go clean with latest de-dup commits on both sides // @headius @enebo |
|
@kares I think this is fine. He is reference 2.3.0 behavior in the MRI link and it removes an issue in MRI test excludes. |
|
@kares merging is a problem but I suspect this one will not be very difficult to know where it fits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MRI
converts it to ratinal
converts self to complex
Ref: https://github.com/ruby/ruby/blob/v2_3_0/rational.c#L1171