Emacs site-lisp subdirectory support
#33416
Merged
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-kenny
force-pushed
the
emacs-site-lisp-subdirectory-support
branch
from
0f1de3a to
68e02e7
Compare
|
@the-kenny In this commit 68e02e7 why did you remove |
|
@mekeor I accidentally added this empty and unused |
`site-start.el` is the file loaded on startup, containing nix-specific customizations like adding paths in `NIX_PROFILES` to the emacs-specific search-path (`load-path`) or making man-pages in these directories discoverable.
This adds subdirectories of `share/emacs/site-lisp/` in every path in `NIX_PROFILES` to `load-path` to allow loading of more complex libraries like `mu4e`. Fixes NixOS#33412
the-kenny
force-pushed
the
emacs-site-lisp-subdirectory-support
branch
from
68e02e7 to
7cfdb2b
Compare
|
@mekeor Just force-pushed rebased commits without the |
|
@GrahamcOfBorg build emacs mu |
There was a problem hiding this comment.
Success on aarch64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18
shrinking /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18/bin/mu
gzipping man pages under /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18/bin
patching script interpreter paths in /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18
checking for references to /build in /nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18...
/nix/store/xajgzwva2lrjxgp7kvp582r59gw9087q-emacs-25.3
/nix/store/p5pkkr11ihmvmc1g4ffd2d4zy87qlbzj-mu-0.9.18
There was a problem hiding this comment.
Success on x86_64-linux (full log)
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18
shrinking /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18/bin/mu
gzipping man pages under /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18/bin
patching script interpreter paths in /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18
checking for references to /tmp/nix-build-mu-0.9.18.drv-0 in /nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18...
/nix/store/0gz8myysca2nf45cvymf085f2bfp9lq2-emacs-25.3
/nix/store/c6f54abciia8sjkj971ycwnma6vy587n-mu-0.9.18
|
@the-kenny Does this look ready to go? Hoping to get this in by 18.03... |
|
@matthewbauer absolutely! :) |
matthewbauer
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This pull request enhances our
site-lisp.elwhich is loaded by Emacs on startup. In addition to adding a bit of documentation it now adds subdirectories of thesite-lispdirectory toload-path, allowing loading of libraries likemu4e.@mekeor: Could you please try this branch and see if it works for you?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)