Use Intrinsics.popcount128 #5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jan 4, 2018
|
I remember some problems with with Int128 on some platforms, missing librt from llvm. What happened with that? |
|
@asterite is there any issues, comments e.g about the failures so that I can check? |
|
But maybe it works out of the box in LLVM 5: #5024 (comment) Probably @RX14 knows more about this. |
asterite
requested changes
Jan 4, 2018
|
Do we have any specs for i128? Aren't they existing but commented out somewhere? |
|
I don't think so. I didn't write them because I thought we'd drop support for them. Let's approve this, we can always add specs later, plus Int128 is mostly implemented by LLVM :-P |
asterite
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
TODO: use after Crystal 0.23.1馃憤