New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl: 2017.12.23 -> 2017.12.31 #33413
Conversation
@GrahamcOfBorg build youtube-dl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: x86_64-linux
/tmp/nix-build-youtube-dl-2017.12.31.drv-0/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31
gzipping man pages under /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/lib /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/bin
patching script interpreter paths in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31
checking for references to /tmp/nix-build-youtube-dl-2017.12.31.drv-0 in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31...
wrapping `/nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/bin/.youtube-dl-wrapped'...
/nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure for system: x86_64-darwin
cannot build derivation ‘/nix/store/9nvimqjxsqymi1gx898bwrxfcs3bm1kd-qtsvg-5.9.3.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/6n6gzzkxwgfcf4kqll7xyngmrw81g7i0-qtxmlpatterns-5.9.3.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/hbfmvxg96pf7hrb1a2z3l69l1271nfqj-qtdeclarative-5.9.3.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/wgkdivh2m0znjprm85ms0q4cwylci7qv-qtmultimedia-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/rn4bx2nzn3hi12ypb0mazpgsgcfsyb79-qtsensors-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/8dyyzjd87bzby8mzic68vbk7n3yjdcrb-qtlocation-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/7kxbz7yrzg90rz31mm51gd4wbjp6iwvy-qtwebkit-5.9.1.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/f2hmqlqy4ywypy63naaa2wkrxy3izy9d-phantomjs-2.1.1.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/sdxhc67j6j3rapbvvxs4100cadm0sc1v-youtube-dl-2017.12.31.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/sdxhc67j6j3rapbvvxs4100cadm0sc1v-youtube-dl-2017.12.31.drv’ failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Success for system: aarch64-linux
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31
gzipping man pages under /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/lib /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/bin
patching script interpreter paths in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31
checking for references to /build in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31...
wrapping `/nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/bin/.youtube-dl-wrapped'...
/nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31
Only the binary is required here right? Could it be acceptable to rely on the user's |
otherwise there is also youtube-dl-light, where this could be disabled. |
@Mic92 phantomjs is only (currently) used for the openload plugin, but it does have its version checked in the plugin independent code: Since there aren't a lot of depedencies in there, that's what convinced me to make it available by default. It does work if you add phantomjs to the same environment with nix-env or e.g. I don't see a |
@corngood if you look into the raw file: https://raw.githubusercontent.com/NixOS/nixpkgs/master/pkgs/top-level/python-packages.nix there is a |
adding |
@Mic92 Ah, I guess that file was too big for github to search. That seems like a good idea. I'll update it later today. |
- add phantomjs2 to PATH for openload plugin
8cdf02f
to
93f30a4
Compare
@Mic92 Updated. I made it consistent with the other optional dependencies, rather than using null on the package. |
Motivation for this change
The youtube-dl openload plugin didn't work without also providing phantomjs.
This does increase dependencies, so I suppose there's an argument for making it optional. Thoughts?
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)