Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: 2017.12.23 -> 2017.12.31 #33413

Merged
merged 1 commit into from Jan 5, 2018
Merged

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Jan 4, 2018

Motivation for this change

The youtube-dl openload plugin didn't work without also providing phantomjs.

This does increase dependencies, so I suppose there's an argument for making it optional. Thoughts?

Things done
  • update youtube-dl to latest release
  • add phantomjs2 to PATH for openload plugin
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

@GrahamcOfBorg build youtube-dl

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/tmp/nix-build-youtube-dl-2017.12.31.drv-0/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31
gzipping man pages under /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/lib  /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/bin 
patching script interpreter paths in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31
checking for references to /tmp/nix-build-youtube-dl-2017.12.31.drv-0 in /nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31...
wrapping `/nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31/bin/.youtube-dl-wrapped'...
/nix/store/xzgy4jf78brqmz06cqcvfnvwxv5a5ciq-youtube-dl-2017.12.31

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

cannot build derivation ‘/nix/store/9nvimqjxsqymi1gx898bwrxfcs3bm1kd-qtsvg-5.9.3.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/6n6gzzkxwgfcf4kqll7xyngmrw81g7i0-qtxmlpatterns-5.9.3.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/hbfmvxg96pf7hrb1a2z3l69l1271nfqj-qtdeclarative-5.9.3.drv’: 4 dependencies couldn't be built
cannot build derivation ‘/nix/store/wgkdivh2m0znjprm85ms0q4cwylci7qv-qtmultimedia-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/rn4bx2nzn3hi12ypb0mazpgsgcfsyb79-qtsensors-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/8dyyzjd87bzby8mzic68vbk7n3yjdcrb-qtlocation-5.9.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/7kxbz7yrzg90rz31mm51gd4wbjp6iwvy-qtwebkit-5.9.1.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/f2hmqlqy4ywypy63naaa2wkrxy3izy9d-phantomjs-2.1.1.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/sdxhc67j6j3rapbvvxs4100cadm0sc1v-youtube-dl-2017.12.31.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/sdxhc67j6j3rapbvvxs4100cadm0sc1v-youtube-dl-2017.12.31.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31
gzipping man pages under /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/lib  /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/bin
patching script interpreter paths in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31
checking for references to /build in /nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31...
wrapping `/nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31/bin/.youtube-dl-wrapped'...
/nix/store/zwdzpf52z7i9zlxlajm1gy6q9d4091z3-youtube-dl-2017.12.31

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2018

Only the binary is required here right? Could it be acceptable to rely on the user's $PATH here for phantomjs?

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2018

otherwise there is also youtube-dl-light, where this could be disabled.

@corngood
Copy link
Contributor Author

corngood commented Jan 4, 2018

@Mic92 phantomjs is only (currently) used for the openload plugin, but it does have its version checked in the plugin independent code:

https://github.com/rg3/youtube-dl/blob/54009c246e8eed38cfa8dc3eecb5619c1c81a1f2/youtube_dl/YoutubeDL.py#L2249

Since there aren't a lot of depedencies in there, that's what convinced me to make it available by default.

It does work if you add phantomjs to the same environment with nix-env or e.g. nix-shell -p youtube-dl -p phantomjs, so this just slightly improves ease of use.

I don't see a youtube-dl-light, do you mean we should add one?

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2018

@corngood if you look into the raw file: https://raw.githubusercontent.com/NixOS/nixpkgs/master/pkgs/top-level/python-packages.nix there is a youtube-dl-light at line ~18000

@Mic92
Copy link
Member

Mic92 commented Jan 4, 2018

adding phantomjs2 = null; should be good for youtube-dl-light

@corngood
Copy link
Contributor Author

corngood commented Jan 4, 2018

@Mic92 Ah, I guess that file was too big for github to search. That seems like a good idea. I'll update it later today.

- add phantomjs2 to PATH for openload plugin
@corngood
Copy link
Contributor Author

corngood commented Jan 4, 2018

@Mic92 Updated. I made it consistent with the other optional dependencies, rather than using null on the package.

@Mic92 Mic92 merged commit b3ba9fb into NixOS:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants