Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-driver: mention $user argument in the NixOS manual and the Impala release notes #33418

Merged
merged 1 commit into from Jan 7, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 4, 2018

Motivation for this change

As the changes made in #32845 affect the NixOS internals, I think that it should be mentioned in the docs and the core.
(/cc @Mic92 sorry for the second PR, forgot to add this in the previous one :))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS (only x86_64-linux)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 force-pushed the test-driver/mention-changes-in-manual branch from 5036795 to e18b0b6 Compare January 6, 2018 09:10
@Ma27
Copy link
Member Author

Ma27 commented Jan 6, 2018

rebased the merge conflict in rl-1803.xml

@Mic92
Copy link
Member

Mic92 commented Jan 7, 2018

Thanks!

@Mic92 Mic92 merged commit 6249d32 into NixOS:master Jan 7, 2018
@Ma27 Ma27 deleted the test-driver/mention-changes-in-manual branch January 7, 2018 01:33
@Ma27
Copy link
Member Author

Ma27 commented Jan 7, 2018

thkanks for merging so fast :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants