Add get_bits() definition #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dericed
reviewed
Jan 4, 2018
ffv1.md
Outdated
| @@ -172,6 +172,10 @@ Several components of FFV1 are described in this document using pseudo-code. Not | |||
|
|
|||
| `byte_aligned( )` is true if `remaining_bits_in_bitstream( NumBytes )` is a multiple of 8, otherwise false. | |||
|
|
|||
| #### get_bits | |||
|
|
|||
| `get_bits( i )` is the action to read the next `i` bits in the bitstream and to return the corresponding value. The current position is increased by `i`. | |||
There was a problem hiding this comment.
nit: better term for current position?
There was a problem hiding this comment.
I guess, I would use the term pointer.
There was a problem hiding this comment.
I reused current position from line 169.
Should I change the term in the same PR?
There was a problem hiding this comment.
I preferred the term current position over pointer but ¯\(ツ)/¯
There was a problem hiding this comment.
blank vote, need another voter.
|
added a commit for changing "current position" to "pointer" |
ablwr
approved these changes
Jan 4, 2018
|
This definition seems unclear in relation to lest significant bit vs most significant bit in a byte first. |
JeromeMartinez
force-pushed
the
get_bits
branch
from
55279d5
to
55e192b
Compare
|
PR updated with addition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no definition of this function.
Issue reported by @dwbuiten