Support LLVM 5.0 postfixed versions #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Jan 4, 2018
RX14
approved these changes
Jan 4, 2018
|
Perhaps we should think about templating those excessively long shell invocations though. |
|
👍 I've been using Crystal with LLVM5 by default for some time now, and found no issues. |
|
@ysbaddaden nice to hear llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a clone of #5013 for LLVM 5.0. See there for reasons.
#5058 already tried that and LLVM 5.0 was not considered sufficiently stable at the time, but it's three months later and it has been promoted to the default version in many distributions, so I think it is fair to make it the default here as well.