Allow nested constants in type lookup for generic arguments that resolve to integers #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jan 4, 2018
bew
reviewed
Jan 4, 2018
| @@ -249,7 +249,7 @@ class Crystal::Type | |||
| end | |||
|
|
|||
| # Check the case of T resolving to a number | |||
| if type_var.is_a?(Path) && type_var.names.size == 1 | |||
| if type_var.is_a?(Path) | |||
There was a problem hiding this comment.
@asterite I'm curious, could you explain why removing this fixes the issue?
There was a problem hiding this comment.
Previously it worked with paths of size one (Foo, Bar, etc.), now it works with any size (Foo::Bar, Foo::Bar::Baz, etc.). The size is the number of types in the path. I don't know why I originally restricted it to one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5426