Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Minio critical security update #34056

Merged
merged 1 commit into from Jan 21, 2018

Conversation

bachp
Copy link
Member

@bachp bachp commented Jan 19, 2018

See #34025

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Critical security fix that fixes an issue that allows
bypassing authentication.

See: https://blog.minio.io/minio-release-jan-18-2018-security-advisory-4c64ca87721b
@grahamc
Copy link
Member

grahamc commented Jan 20, 2018

@GrahamcOfBorg build minio

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

error: while evaluating the attribute 'buildInputs' of the derivation 'minio-2018-01-18T20-33-21Z' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
while evaluating the attribute 'GOARCH' of the derivation 'go-1.9.2' at /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/stdenv/generic/make-derivation.nix:98:11:
Unsupported system

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/cloud.google.com/go/internal/version/update_version.sh: interpreter directive changed from "/bin/bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/certs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/sh"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/sh"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash -e"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
/nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/jgw8hxx7wzkyhb2dr9hwsd9h2caaasdc-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-minio-2018-01-18T20-33-21Z.drv-0 in /nix/store/l4hfhm85mkb90d0cgvgl9nlh51rs23p2-minio-2018-01-18T20-33-21Z...
/nix/store/p7vskp5wxbar91a395a3x2d0wwbmnqkj-minio-2018-01-18T20-33-21Z-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/buildscripts/benchcmp.sh: interpreter directive changed from "/bin/bash          " to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/cloud.google.com/go/internal/version/update_version.sh: interpreter directive changed from "/bin/bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/codegen.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/grpc/coverage.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/google.golang.org/appengine/internal/regen.sh: interpreter directive changed from "/bin/bash -e" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash -e"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/bash"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/gen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/sh"
/nix/store/ghgd4gmfvh8h2akldfsc79zl94rfk5jx-minio-2018-01-18T20-33-21Z/share/go/src/github.com/minio/minio/vendor/github.com/streadway/amqp/certs.sh: interpreter directive changed from "/bin/sh" to "/nix/store/03pdhzb1qlgn4jil6kbxy75dcqpd1m1a-bash-4.4-p12/bin/sh"
/nix/store/i762w7jcdkdswc4vz5idfmlkjnnir9ds-minio-2018-01-18T20-33-21Z-bin

@bachp
Copy link
Member Author

bachp commented Jan 21, 2018

@grahamc ping

@grahamc grahamc merged commit 013662f into NixOS:release-17.09 Jan 21, 2018
@grahamc
Copy link
Member

grahamc commented Jan 21, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants