Avoid using util::function for thread function wrappers #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Jan 19, 2018
| inline threads::thread_result_type operator()(threads::thread_arg_type) | ||
| { | ||
| // execute the actual thread function | ||
| f(); |
There was a problem hiding this comment.
Shouldn't this be forwarded as well (same as https://github.com/STEllAR-GROUP/hpx/pull/3114/files#diff-f5e3956f6930a2fde1e87c0917f65d6bR799)?
There was a problem hiding this comment.
The forward has no effect here. It should rather be removed on the other spot. Good catch.
|
@sithhell how much of an improvement do you see from this change? |
sithhell
force-pushed
the
thread_function
branch
from
19414ab
to
134b498
Compare
For a htts like scenario, with a granularity of 10 us, this is the speedup over current master: For all other tested grain sizes, there is no noticable difference. |
sithhell
force-pushed
the
thread_function
branch
from
134b498
to
ba9e815
Compare
Currently, the non-plain versions of the register_work/register_thread functions make use of util::function. This leads due unnecessary dynamic memory allocation since the potential for util::function using the small object optimization is limited.
sithhell
force-pushed
the
thread_function
branch
from
ba9e815
to
93951d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the non-plain versions of the register_work/register_thread functions
make use of util::function. This leads due unnecessary dynamic memory allocation
since the potential for util::function using the small object optimization is
limited.