Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to exclusive_scan algorithm #3112

Closed
wants to merge 1 commit into from
Closed

Minor fixes to exclusive_scan algorithm #3112

wants to merge 1 commit into from

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 19, 2018

  • removed unneeded temporary variable

@hkaiser
Minor fixes to exclusive_scan algorithm
24831ed 
- removed unneeded temporary variable
@hkaiser hkaiser added this to the 1.1.0 milestone Jan 19, 2018
sithhell
sithhell approved these changes Jan 19, 2018
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkaiser
Copy link
Member Author

hkaiser commented Jan 19, 2018

Looks like the change breaks the tests - will investigate...

@hkaiser
Copy link
Member Author

hkaiser commented Jan 19, 2018

Closing as invalid as the change breaks overlapping input and output sequences.

@hkaiser hkaiser closed this Jan 19, 2018
@hkaiser hkaiser deleted the exclusive_scan branch January 19, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: algorithms tag: invalid
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell