serviio: init at 1.9 #34053
Merged
serviio: init at 1.9 #34053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachp
requested changes
Jan 19, 2018
pkgs/servers/serviio/default.nix
Outdated
| Serviio is a free media server. It allows you to stream your media files (music, video or images) | ||
| to any DLNA-certified renderer device (e.g. a TV set, Bluray player, games console) on your home network. | ||
| ''; | ||
| license = licenses.free; |
There was a problem hiding this comment.
I don't think this is true. From checking their website I don't see any sources and it seems this is proprietary software.
licenses.unfree seems more appropriate.
Their download page also states:
By downloading this software you agree to the terms of the End User Licence Agreement. For commercial licence details look at the Contact page.
There was a problem hiding this comment.
You're right, I hesitated. It's kind of "Freemium". Fully functional during 14 days with the Pro version, then free with limited features.
bachp
approved these changes
Jan 19, 2018
|
@GrahamcOfBorg build serviio |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘serviio-1.9’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/servers/serviio/default.nix:21 has an unfree license (‘unfree’), refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-linux
Package ‘serviio-1.9’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/servers/serviio/default.nix:21 has an unfree license (‘unfree’), refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-darwin
Package ‘serviio-1.9’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/servers/serviio/default.nix:21 has an unfree license (‘unfree’), refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.
matthewbauer
approved these changes
Feb 6, 2018
|
@GrahamcOfBorg build serviio |
Mic92
reviewed
Feb 10, 2018
| -Dderby.system.home=${cfg.dataDir}/library -Dserviio.home=${cfg.dataDir} -Dffmpeg.location=${pkgs.ffmpeg}/bin/ffmpeg -Ddcraw.location=${pkgs.dcraw}/bin/dcraw" | ||
|
|
||
| # Execute the JVM in the foreground | ||
| exec ${pkgs.jre}/bin/java -Xmx512M -Xms20M -XX:+UseG1GC -XX:GCTimeRatio=1 -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 $JAVA_OPTS -classpath "$SERVIIO_CLASS_PATH" org.serviio.MediaServer "$@" |
There was a problem hiding this comment.
This should be part of the package. You can create it there with the makeWrapper function.
|
@GrahamcOfBorg build serviio |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Serviio is a free media server. It allows you to stream your media files (music, video or images) to any DLNA-certified renderer device (e.g. a TV set, Bluray player, games console) on your home network.
Things done
package + nixos option
tested with NixOps on a virtualbox machine.
Tested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.