Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: add qemu to PATH for libvirtd #34048

Closed
wants to merge 2 commits into from

Conversation

erosennin
Copy link
Contributor

Motivation for this change

libvirtd requires qemu-img to manage disk images.

If qemu-img is not found by libvirtd, attempting to create a qcow2 image fails with this error:

$ cat >/tmp/vol.xml <<EOF
<volume>
  <name>test</name>
  <capacity>1000</capacity>
  <target>
    <format type="qcow2"/>
  </target>
</volume>
EOF
$ virsh -c qemu:///system vol-create --pool default --file /tmp/vol.xml
error: Failed to create vol from /tmp/vol.xml
error: internal error: creation of non-raw file images is not supported without qemu-img.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erosennin
Copy link
Contributor Author

How about splitting qemu-img into a separate package then? It does not depend on QEMU and supports almost every virtual disk format in existence. There can be so many use cases where it can be useful without QEMU.

@erosennin
Copy link
Contributor Author

@volth Sure.

@erosennin erosennin closed this Jan 19, 2018
@erosennin erosennin deleted the libvirtd-qemu-path branch January 24, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant