Skip to content

Commit

Permalink
Exclude MRI test that checks thread lists. See #4960
Browse files Browse the repository at this point in the history
JRuby's list of threads may include those that come from outside
JRuby itseld, like JVM finalizer or worker threads. Because this
might happen at some unknown time in the future, it causes tests
relying on Thread.list to fail sporadically.
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch jruby-9.1
# Your branch is up-to-date with 'origin/jruby-9.1'.
#
# Changes to be committed:
#	modified:   test/mri/excludes/TestThread.rb
#
# Untracked files:
#	bench1.rb
#	bench2.rb
#	blah
#	blah.rb
#	blah.sh
#	blah2.rb
#	jruby_jetpdb/
#	link20180108-44247-163yxpr
#	nic.rb
#	ripper_bug_4792.rb
#	run_jruby.sh
#	test/jruby/tcttac37356-0.jpg
#	test/jruby/testapp/testapp
#	test_thr_kill_count
#	testapp2/
#	tmp/
#	var/
#	"\316\261.rb"
#	"\343\201\202"
#
headius committed Jan 9, 2018
1 parent f5539dc commit 2148feb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/mri/excludes/TestThread.rb
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
exclude :test_handle_interrupt, "handle_interrupt is not working properly"
exclude :test_handle_interrupt_and_p, "handle_interrupt is not working properly"
exclude :test_handle_interrupt_blocking, "handle_interrupt is not working properly"
exclude :test_list, "JVM finalizer threads get adopted, randomly skewing the result (#4960)"
exclude :test_main_thread_status_at_exit, "we do not set main thread to aborting when it terminates; differing opinions on thread lifecycle at main shutdown"
exclude :test_main_thread_variable_in_enumerator, "differing notions of current thread within a fiber"
exclude :test_mutex_interrupt, "hangs"

0 comments on commit 2148feb

Please sign in to comment.