Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomcat{7,8,85,9} fixes for CVE-201712617 & tomcat9 stable bump #33631

Merged
merged 4 commits into from Jan 9, 2018

Conversation

andir
Copy link
Member

@andir andir commented Jan 8, 2018

Motivation for this change

Randomly browsed the package repo, found open RCE issues. Also updated (& renamed) tomcatUnstable to the released tomcat 9 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Jan 8, 2018

@GrahamcOfBorg build tomcat7 tomcat8 tomcat85 tomcat9

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

builder for ‘/nix/store/g8glrs3mwkfds4l9f3y85ja86ybpc2fa-apache-tomcat-8.0.47.tar.gz.drv’ failed with exit code 254
builder for ‘/nix/store/inllrddq6pcn2yi3p6jqqr0niyqmicya-apache-tomcat-8.5.23.tar.gz.drv’ failed with exit code 254
cannot build derivation ‘/nix/store/hzv4phn797888ad0xq8sd1iym8yvhrbs-apache-tomcat-7.0.82.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/hxvnkd090yqr34qxbhnz7ysxac6dfxki-apache-tomcat-8.0.47.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/0ay95cbb8qlpgyqs3vx5z3g0ln67xs9k-apache-tomcat-8.5.23.drv’: 1 dependencies couldn't be built
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
/nix/store/zsn4rc9p48hsq6a53357fmk314b0ahg4-stdenv-darwin/setup: fork: Operation not permitted
builder for ‘/nix/store/mfyd3pcq8v2frmgc1pfq2563idz04bik-apache-tomcat-9.0.2.tar.gz.drv’ failed with exit code 254
cannot build derivation ‘/nix/store/r19rad26b3ybf4vx3mp8xni0sb77gpan-apache-tomcat-9.0.2.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/0ay95cbb8qlpgyqs3vx5z3g0ln67xs9k-apache-tomcat-8.5.23.drv’, ‘/nix/store/hxvnkd090yqr34qxbhnz7ysxac6dfxki-apache-tomcat-8.0.47.drv’, ‘/nix/store/hzv4phn797888ad0xq8sd1iym8yvhrbs-apache-tomcat-7.0.82.drv’, ‘/nix/store/r19rad26b3ybf4vx3mp8xni0sb77gpan-apache-tomcat-9.0.2.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/8rv5gi7fvs0v74gk2yj3ix5b4rvxpdab-apache-tomcat-9.0.2/bin/daemon.sh: interpreter directive changed from "/bin/sh" to "/nix/store/nkq0n2m4shlbdvdq0qijib5zyzgmn0vq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-apache-tomcat-9.0.2.drv-0 in /nix/store/8rv5gi7fvs0v74gk2yj3ix5b4rvxpdab-apache-tomcat-9.0.2...
shrinking RPATHs of ELF executables and libraries in /nix/store/5lih3zgbblfxkj3s0ygjb56idva6bywc-apache-tomcat-9.0.2-webapps
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/5lih3zgbblfxkj3s0ygjb56idva6bywc-apache-tomcat-9.0.2-webapps
checking for references to /tmp/nix-build-apache-tomcat-9.0.2.drv-0 in /nix/store/5lih3zgbblfxkj3s0ygjb56idva6bywc-apache-tomcat-9.0.2-webapps...
/nix/store/118w9iv33fpn5c1y9wny7hischq44pxp-apache-tomcat-7.0.82
/nix/store/5fdb9swii07x8xmadfvn10bxki9lil80-apache-tomcat-8.0.47
/nix/store/fs524bjm3krcx5wqgnsinh28bdd40nxq-apache-tomcat-8.5.23
/nix/store/8rv5gi7fvs0v74gk2yj3ix5b4rvxpdab-apache-tomcat-9.0.2

@globin globin merged commit 637d5dd into NixOS:master Jan 9, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/s2hpxdk83aznlqyrh2h9h7xvvlhmhq20-apache-tomcat-8.0.47-webapps
checking for references to /build in /nix/store/s2hpxdk83aznlqyrh2h9h7xvvlhmhq20-apache-tomcat-8.0.47-webapps...
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/m1rbs4ll5fqfp39mam79sd8dzd35xnfh-apache-tomcat-8.5.23-webapps
checking for references to /build in /nix/store/m1rbs4ll5fqfp39mam79sd8dzd35xnfh-apache-tomcat-8.5.23-webapps...
/nix/store/49dshb52wbg5xmbnbrwv001f03gli07y-apache-tomcat-7.0.82
/nix/store/1cvm7fi00nhcj8wq4mwa2c2s4q0m7rh2-apache-tomcat-8.0.47
/nix/store/biw1wfrbd2b2p5dvnwvz5q3fmw9zs3km-apache-tomcat-8.5.23
/nix/store/1nh63rq7w03sdwbg2y88h0fibqqgni3x-apache-tomcat-9.0.2

@andir andir deleted the update-tomcat branch January 9, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants