Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: Kill off ensureDir #33637

Merged
merged 1 commit into from Jan 9, 2018
Merged

stdenv: Kill off ensureDir #33637

merged 1 commit into from Jan 9, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 9, 2018

Motivation for this change

Spotted this old relic and decided to kill it off

Ran a nox-review wip before removing the lines from pkgs/stdenv/generic/setup.sh and it succeded.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it's been removed already :-)

@edolstra edolstra merged commit 718a9ad into NixOS:staging Jan 9, 2018
jonringer pushed a commit to NixOS/nix-pills that referenced this pull request May 2, 2020
ensureDir was dropped with the merge of NixOS/nixpkgs#33637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants