Added JDK dependency to libguestfs #33642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Disabling Java bindings seems vastly preferable to adding a dependency on the JDK. |
|
Fair enough. I'll add an option to disable Java bindings later tonight. |
This is required with the current set of configure flags
nightkr
force-pushed
the
libguestfs-java
branch
from
1065b4c
to
440cfd3
Compare
|
@edolstra Does this look better to you? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current libguestfs package doesn't build, unless you patch it to either include the JDK dependency, or to disable the Java bindings.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Ideally the language bindings should probably be managed by flags, so that they can be enabled/disabled per language, but at least this gets the package buildable.