Revert "gcc, binutils: Get rid of 32-bit ARM configure flag exception" #33641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit breaks native armv7l-linux builds. Revert it until it can be root-caused. This reversion does not affect other platforms or cross-compiling. This reverts commit 0f5c804.
orivej
approved these changes
Jan 9, 2018
|
Thank you! |
|
Yeah this is totally justified. Sorry I didn't do it myself :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0f5c804 broke native
armv7l-linuxbuilds. @Ericson2314 understandably has his hands full, so in the meantime, I would like to un-wedgearmv7l-linuxuntil he has a chance to revisit this. It is currently not possible to build practically anything for that platform onmasteror on any of theunstablechannels.This reversion does not affect behavior on other platforms or for
armv7l-linuxcross-compiling, as far as I can tell.I tested this on
masterby successfully building a Linux kernel and its dependencies.Motivation for this change
Fixes #33403
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)