Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: add ninja to propagatedNativeBuildInputs #33632

Closed
wants to merge 1 commit into from
Closed

meson: add ninja to propagatedNativeBuildInputs #33632

wants to merge 1 commit into from

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Jan 8, 2018

Motivation for this change

This increases the degree to which meson builds in nixpkgs Just Work. By propagating ninja through by default, we avoid every downstream package needing to explicitly include it. The addition of mesonCheckPhase further allows doCheck = true; alone to run any test suites meson is aware of.

This is the first time I've touched a setup hook, so careful review is very welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej requested a review from jtojnar January 9, 2018 00:01
@orivej
Copy link
Contributor

orivej commented Jan 9, 2018

Meson check phase was implemented in #33311.

@Ralith
Copy link
Contributor Author

Ralith commented Jan 9, 2018

Whoops. I'll remove that part, then.

@Ralith Ralith changed the title Meson quality of life improvements meson: add ninja to propagatedNativeBuildInputs Jan 9, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Jan 9, 2018

Meson can, in theory, use other builders than Ninja. This is not very useful in nixpkgs but I can imagine someone on Darwin installing meson through nix and then using it with Xcode.

@Ralith
Copy link
Contributor Author

Ralith commented Jan 15, 2018

Fair enough!

@Ralith Ralith closed this Jan 15, 2018
@Ralith Ralith deleted the meson-check branch January 15, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ralith @orivej @jtojnar @GrahamcOfBorg