Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avidemux: support alsa #33753

Merged
merged 1 commit into from Jan 13, 2018
Merged

avidemux: support alsa #33753

merged 1 commit into from Jan 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2018 •
edited by ghost

Motivation for this change

Avidemux currently doesn't support bare Alsa output, only PulseAudio. Fix that.
cc maintainers @viric @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 4acd2f1 into NixOS:master Jan 13, 2018
@ghost
Copy link
Author

ghost commented Jan 13, 2018

@Mic92 Thanks!

@ghost ghost deleted the avidemux branch January 13, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg