Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/keymap: disable xterm DM #33755

Merged
merged 1 commit into from Jan 13, 2018
Merged

nixos/tests/keymap: disable xterm DM #33755

merged 1 commit into from Jan 13, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 11, 2018 •
edited

Motivation for this change

Another go at alleviating the flaky keymap tests.

Things done

The xterm display manager has been disabled. The test spins up its own xterm, but sometimes the DM xterm would be in focus instead, causing failures..

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb srhb mentioned this pull request Jan 11, 2018
Closed
8 tasks
@srhb
Copy link
Contributor Author

srhb commented Jan 11, 2018

@GrahamcOfBorg test keymap.colemak

GrahamcOfBorg
GrahamcOfBorg reviewed Jan 11, 2018
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

fetching path ‘/nix/store/njm35d3d0aanw1fi6khhmxsh9mhnfq7x-btrfs-progs-4.14.1’...

*** Downloading ‘https://cache.nixos.community/nar/1flpv3rryrivnpqvhxm394ma4pf111y8d6z7j32arrrm049flm2l.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/njm35d3d0aanw1fi6khhmxsh9mhnfq7x-btrfs-progs-4.14.1’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   117  100   117    0     0    117      0  0:00:01 --:--:--  0:00:01  2785

100  629k  100  629k    0     0   629k      0  0:00:01 --:--:--  0:00:01  629k

building path(s) ‘/nix/store/0fvpn2305hwbz9gzk3zc805l0s43imgd-Xresources-Xft’
error: a ‘aarch64-linux’ is required to build ‘/nix/store/50jzcfx3gpm7bn6hx4k448x9gjdb74p0-Xresources-Xft.drv’, but I am a ‘x86_64-linux’

@Mic92 Mic92 merged commit 91ec1f7 into NixOS:master Jan 13, 2018
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2018

Thanks!

@vcunat
Copy link
Member

vcunat commented Jan 14, 2018

Hmm, 2/6 keymap tests failed on Hydra :-(

@srhb
Copy link
Contributor Author

srhb commented Jan 14, 2018

@vcunat I noticed. :/ I'm not quite sure what's causing it, but I am considering reviving #33719 with a delay before the initial focus attempt in order to remedy it. It would be grand if someone has a better idea at debugging this, however, since I'm just piling workaround upon workaround...

@globin
Copy link
Member

globin commented Jan 15, 2018

ping @aszlig

@Mic92
Copy link
Member

Mic92 commented Jan 15, 2018

The test is pretty complex, is there a way to simplify the code?

@rnhmjoj rnhmjoj mentioned this pull request Nov 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srhb @Mic92 @vcunat @globin @GrahamcOfBorg