Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-manager: add gobjectIntrospection to nativeBuildInputs #33754

Merged
merged 1 commit into from Jan 14, 2018

Conversation

erosennin
Copy link
Contributor

Another package broken by removal of gobjectIntrospection from propagatedBuildInputs of atk (6bbec17).

This is similar to ea595a0, 5350b0f, 2a1425d, d99321c, etc.

Motivation for this change

Without this, virt-manager fails to start with this error:

Traceback (most recent call last):
  File "/nix/store/5fvw5w6bykry9yqnz0wfrn39s7x3fhcx-virt-manager-1.4.3/share/virt-manager/virt-manager", line 32, in <module>
    gi.require_version('LibvirtGLib', '1.0')
  File "/nix/store/p6fnhmmvr28ziv19c37hr9n6vkcy25an-python2.7-pygobject-3.26.1/lib/python2.7/site-packages/gi/__init__.py", line 130, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace LibvirtGLib not available
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@erosennin
Copy link
Contributor Author

Actually, would it make sense to propagate the dependency automatically?

@concatime
Copy link
Contributor

Faced this exact issue. Hope it will get resolved quickly ;)

@jtojnar jtojnar force-pushed the virt-manager-gobject-introspection branch from b88a9b6 to 3eb0ddc Compare January 14, 2018 12:32
@jtojnar
Copy link
Contributor

jtojnar commented Jan 14, 2018

Thanks.

@jtojnar jtojnar merged commit 3eb0ddc into NixOS:master Jan 14, 2018
@erosennin erosennin deleted the virt-manager-gobject-introspection branch January 24, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants