youtube-dl: disable phantomjs support on darwin by default #33767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build youtube-dl |
There was a problem hiding this comment.
Success for system: aarch64-linux
copying path '/nix/store/4la692abkpshf0q6y917mzbsljmpizwn-qtsensors-5.9.3-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/298wk4ja3m5vvp04ybnb7dxr66h6p1j0-qtmultimedia-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/1x2y4lzl1wrlccs2kn26wywqsg43nk93-qtlocation-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/z16j01mczdxid67aw16knkvw11jl1w8m-qtmultimedia-5.9.3-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/crmx2pjbp8p1a553gwfcn7v4nqkcn942-qtlocation-5.9.3-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/7w6n9xcm3rc0yx54dzig40ij8l1fbq7i-qtwebkit-5.9.1' from 'https://cache.nixos.org'...
copying path '/nix/store/2rcxxgd9v22liz8d83fmvya3y81nksv2-qtwebkit-5.9.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/kmijwf2swz4mncr43vkj177y1a1xf9lq-phantomjs-2.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/ksxvsdnb7h7wf3zfz30k51r0l614l5fv-youtube-dl-2017.12.31' from 'https://cache.nixos.org'...
/nix/store/ksxvsdnb7h7wf3zfz30k51r0l614l5fv-youtube-dl-2017.12.31
There was a problem hiding this comment.
Success for system: x86_64-linux
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 385k 100 385k 0 0 385k 0 0:00:01 --:--:-- 0:00:01 3039k
fetching path ‘/nix/store/ldscaphsgw4vnx5lbs6dz9dg6gkv233x-youtube-dl-2017.12.31’...
*** Downloading ‘https://nix-cache.s3.amazonaws.com/nar/18ygclb4h0d4jpykp13qarfqryral1pjzjdkgx62jw40kak8n3vi.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/ldscaphsgw4vnx5lbs6dz9dg6gkv233x-youtube-dl-2017.12.31’...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
81 1696k 81 1375k 0 0 1375k 0 0:00:01 --:--:-- 0:00:01 6368k
100 1696k 100 1696k 0 0 1696k 0 0:00:01 --:--:-- 0:00:01 6785k
/nix/store/ldscaphsgw4vnx5lbs6dz9dg6gkv233x-youtube-dl-2017.12.31
There was a problem hiding this comment.
Success for system: x86_64-darwin
Installing collected packages: youtube-dl
Successfully installed youtube-dl-2017.12.31
/private/tmp/nix-build-youtube-dl-2017.12.31.drv-0/youtube-dl
post-installation fixup
gzipping man pages under /nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31/share/man/
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31/lib /nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31/bin
patching script interpreter paths in /nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31
wrapping `/nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31/bin/.youtube-dl-wrapped'...
/nix/store/jvymk27wr7d6xgvx0zxc8l2i88gvx58v-youtube-dl-2017.12.31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@jwiegley pointed out that phantomjs2 is broken on darwin.
Could someone test this on macos, or trigger a robot build?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)