Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new constructor. #3123

Merged
merged 2 commits into from Jan 24, 2018
Merged

Add new constructor. #3123

merged 2 commits into from Jan 24, 2018

Conversation

stevenrbrandt
Copy link
Member

@stevenrbrandt stevenrbrandt commented Jan 23, 2018 •
edited by hkaiser

Fixes # The hello world component no longer compiled

@hkaiser hkaiser added this to the 1.1.0 milestone Jan 23, 2018
hkaiser
hkaiser approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sithhell sithhell merged commit 4ba45e7 into master Jan 24, 2018
@sithhell sithhell deleted the fix_hello branch January 24, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: examples type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenrbrandt @hkaiser @sithhell