Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moe: fix build w/libc++ using touchup from mailing list #34206

Merged
merged 1 commit into from Jan 24, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 23, 2018

http://lists.gnu.org/archive/html/bug-moe/2017-10/msg00000.html

Motivation for this change

Fix build w/libc++.

Example (fails currently, succeeds after this fix):

$ nix build "(with import ./. {}; moe.override { stdenv = llvmPackages_4.libcxxStdenv; })" 
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 24, 2018

@GrahamcOfBorg build moe

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘moe-1.9’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/editors/moe/default.nix:26 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

install -m 644 ./doc/moe.1 "/nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9/share/man/man1/moe.1"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9
shrinking /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9/bin/moe
gzipping man pages under /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9/share/man/
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9/bin 
patching script interpreter paths in /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9
checking for references to /tmp/nix-build-moe-1.9.drv-0 in /nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9...
/nix/store/ai3c4pgkxqibv7ipsvfnhivzljc41cyg-moe-1.9

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

install -m 644 ./doc/moe.1 "/nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9/share/man/man1/moe.1"
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9
shrinking /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9/bin/moe
gzipping man pages under /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9/share/man/
strip is /nix/store/jwz859pxqj7sl2dbwvmxkx68jp774izb-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9/bin
patching script interpreter paths in /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9
checking for references to /build in /nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9...
/nix/store/qhnvs873cdrdyw5kqhk0b0c7diyvf96c-moe-1.9

@grahamc grahamc merged commit 0e7a520 into NixOS:master Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants