Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "ghc-mod" to darwin stable channel #34203

Closed
wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

ghc-mod (and other Haskell packages) are frequently broken on the stable channel. Adding it here hopefully will make it a little bit more noticeable.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ghc-mod (and other Haskell packages) are frequently broken on the stable channel. Adding it here hopefully will make it a little bit more noticeable.
@LnL7
Copy link
Member

LnL7 commented Jan 24, 2018

Given the recent rust issues (see #34189) we should probably have a more general discussion on what kinds of things should block channel updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants