Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obscure corner case in name resolution for builtin:fetchurl in sandboxed environments #1813

Merged
merged 1 commit into from Jan 23, 2018
Merged

Fix obscure corner case in name resolution for builtin:fetchurl in sandboxed environments #1813

merged 1 commit into from Jan 23, 2018

Conversation

copumpkin
Copy link
Member

Unfortunately this currently displays a few warnings like the following:

warning: unable to download 'http://this.pre-initializes.the.dns.resolvers.invalid': Couldn't resolve host name (6); retrying in 285 ms
warning: unable to download 'http://this.pre-initializes.the.dns.resolvers.invalid': Couldn't resolve host name (6); retrying in 668 ms
warning: unable to download 'http://this.pre-initializes.the.dns.resolvers.invalid': Couldn't resolve host name (6); retrying in 1234 ms
warning: unable to download 'http://this.pre-initializes.the.dns.resolvers.invalid': Couldn't resolve host name (6); retrying in 2106 ms

which I don't know how to suppress. @edolstra, any ideas?

@copumpkin
Copy link
Member Author

I suppose I could add an bool stfu field to DownloadRequest to shut up the warning, but that feels messy.

@copumpkin
Copy link
Member Author

Just verified that tries = 1 silences the warnings too.

@edolstra edolstra merged commit b76e282 into NixOS:master Jan 23, 2018
@vcunat
Copy link
Member

vcunat commented Jan 23, 2018

Right, **.invalid query shouldn't even make it past the first (reasonable) resolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@copumpkin @vcunat @edolstra