rust: fix glibc build #34205
Merged
rust: fix glibc build #34205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There currently are two more approaches to fix
|
This was referenced Jan 24, 2018
vcunat
reviewed
Jan 24, 2018
| @@ -101,6 +101,10 @@ stdenv.mkDerivation { | |||
| # Useful debugging parameter | |||
| # export VERBOSE=1 | |||
| '' | |||
| + optionalString (stdenv ? glibc) '' | |||
| # Disable test for glibc-2.26 | |||
There was a problem hiding this comment.
Nitpick: it's patched glibc-2.25.
|
I think disabling the whole test as in this PR is the best way, at least for now. |
|
Yeah, unless it really is a glibc bug ofcorse but doesn't look like that's the case. |
|
One thing that irritates me is that the test remains unchanged in newest |
vcunat
approved these changes
Jan 25, 2018
vcunat
added a commit
that referenced
this pull request
Jan 25, 2018
... after applying glibc patches. It's not clear (yet) why this older rustc (test) got broken. Newer rustc (used for Firefox) has the very same test that still passes.
|
Strange, but I see no use in delaying any more. We can improve later, when/if we find out more. |
|
Oh of course! I'm happy there is a solution to the issue in. Thanks for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tested rustc, cargo and a few rust packages.
/cc @vcunat
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)