release: appease checkMeta by using string for schedulingPriority #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzWill
force-pushed
the
fix/schedprio-checkmeta
branch
from
12b1a69
to
9a04949
Compare
|
Hmm sure seems like nixpkgs is wrong.
…On Tue, Jan 9, 2018 at 8:17 AM Will Dietz ***@***.***> wrote:
See
https://github.com/NixOS/nixpkgs/blob/ae9a7c4969c70950f7c92ba487069ca5091ecca2/pkgs/stdenv/generic/check-meta.nix#L165
.
Either that's wrong or this is :).
------------------------------
You can view, comment on, or merge this pull request online at:
#1786
Commit Summary
- release: appease checkMeta by using string for schedulingPriority
File Changes
- *M* release.nix <https://github.com/NixOS/nix/pull/1786/files#diff-0>
(2)
Patch Links:
- https://github.com/NixOS/nix/pull/1786.patch
- https://github.com/NixOS/nix/pull/1786.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1786>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAErrMVpmUoelHBp7O1AEcpRX9FwAl3Xks5tI2bTgaJpZM4RXz6R>
.
|
|
It was probably made a string because the only instance of it in-tree is also a string: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/release/source-tarball.nix#L126 Curiously Nix's release.nix uses this as well, so ... neither type is right?! 📦 Just kidding, |
8 tasks
|
IIRC, once upon a time, meta attributes had to be strings, but that's no longer the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/NixOS/nixpkgs/blob/ae9a7c4969c70950f7c92ba487069ca5091ecca2/pkgs/stdenv/generic/check-meta.nix#L165 .
Either that's wrong or this is :).