Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord: 0.0.3 -> 0.0.4 #33660

Closed
wants to merge 1 commit into from
Closed

discord: 0.0.3 -> 0.0.4 #33660

wants to merge 1 commit into from

Conversation

TravisWhitehead
Copy link

@TravisWhitehead TravisWhitehead commented Jan 9, 2018

Motivation for this change

Update Discord to version 0.0.4.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@MP2E 馃槂

@dtzWill
Copy link
Member

dtzWill commented Jan 9, 2018

Looks like this was pushed to master: 3ffb413

@TravisWhitehead
Copy link
Author

Ah, my bad. Guess I forgot to pull this morning.

@TravisWhitehead TravisWhitehead deleted the discord-0.0.4 branch January 9, 2018 19:06
@etu
Copy link
Contributor

etu commented Jan 9, 2018

Is this backported to 17.06 as well? Because if i's not, that package is broken because Discord make all clients that are out of date prompt the user that they need to update the client.

@dtzWill
Copy link
Member

dtzWill commented Jan 9, 2018

Nope, it's still on 0.0.3 it looks like.

Hopefully someone can pick the commit over for us! 馃檹

(might want to grab #33585 as well, assuming it's approved soon)

@MP2E
Copy link

MP2E commented Jan 11, 2018

I'll backport it tonight! Going to test 2 PRs related to discord and get those into master first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants