Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whois: use idn, libiconv; update #33650

Merged
merged 3 commits into from Jan 13, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2018

Motivation for this change

Support "international" domains, and update to latest while at it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 9, 2018

@Mic92
Copy link
Member

Mic92 commented Jan 13, 2018

@GrahamcOfBorg build whois

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

install -m 0644 whois.conf.5 /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20/share/man/man5/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20
shrinking /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20/bin/whois
gzipping man pages under /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20/bin 
patching script interpreter paths in /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20
checking for references to /tmp/nix-build-whois-5.2.20.drv-0 in /nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20...
/nix/store/fn82n71wg2f19zvbbnp3kspyqnwzqb8h-whois-5.2.20

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

install -m 0644 whois.conf.5 /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20/share/man/man5/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20
shrinking /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20/bin/whois
gzipping man pages under /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20/bin
patching script interpreter paths in /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20
checking for references to /build in /nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20...
/nix/store/vjj2cjn2da2y8fvd4z8si4nacayr2x0i-whois-5.2.20

@Mic92 Mic92 merged commit 9e40faf into NixOS:master Jan 13, 2018
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘whois-5.2.20’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/tools/networking/whois/default.nix:31 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants