Fix off-by-one in log output line length (#6896)

Pedro Gimeno · SmallJoker · commit f77f19a9412c · 2018-01-09T19:07:14.000+01:00
diff --git a/src/log.cpp b/src/log.cpp
@@ -347,13 +347,10 @@ void StringBuffer::push_back(char c)
 			flush(std::string(buffer, buffer_index));
 		buffer_index = 0;
 	} else {
-		int index = buffer_index;
-		buffer[index++] = c;
-		if (index >= BUFFER_LENGTH) {
+		buffer[buffer_index++] = c;
+		if (buffer_index >= BUFFER_LENGTH) {
 			flush(std::string(buffer, buffer_index));
 			buffer_index = 0;
-		} else {
-			buffer_index = index;
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -347,13 +347,10 @@ void StringBuffer::push_back(char c)`
`347`	`347`	`flush(std::string(buffer, buffer_index));`
`348`	`348`	`buffer_index = 0;`
`349`	`349`	`} else {`
`350`		`- int index = buffer_index;`
`351`		`- buffer[index++] = c;`
`352`		`- if (index >= BUFFER_LENGTH) {`
	`350`	`+ buffer[buffer_index++] = c;`
	`351`	`+ if (buffer_index >= BUFFER_LENGTH) {`
`353`	`352`	`flush(std::string(buffer, buffer_index));`
`354`	`353`	`buffer_index = 0;`
`355`		`- } else {`
`356`		`- buffer_index = index;`
`357`	`354`	`}`
`358`	`355`	`}`
`359`	`356`	`}`