libvorbis: Fix CVE-2017-14160, CVE-2017-14632 & CVE-2017-14633 #33662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ehmry |
|
@GrahamcOfBorg build libvorbis darkice |
There was a problem hiding this comment.
Failure for system: aarch64-linux
Package ‘faac-1.29.9.2’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Failure for system: x86_64-linux
Package ‘faac-1.29.9.2’ in /var/lib/gc-of-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/globin-server/pkgs/development/libraries/faac/default.nix:32 has an unfree license (‘unfreeRedistributable’), refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.
|
@GrahamcOfBorg build libvorbis icecast |
There was a problem hiding this comment.
Success for system: x86_64-linux
make[1]: Leaving directory '/tmp/nix-build-icecast-2.4.3.drv-0/icecast-2.4.3'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3
shrinking /nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3/bin/icecast
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3/bin
patching script interpreter paths in /nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3
checking for references to /tmp/nix-build-icecast-2.4.3.drv-0 in /nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3...
/nix/store/1xj62czsfqg64s45ijn7aa14cd9yrd09-libvorbis-1.3.5
/nix/store/vfdrsql615rp737lncbc857pda24gsay-icecast-2.4.3
There was a problem hiding this comment.
Success for system: aarch64-linux
make[1]: Leaving directory '/build/icecast-2.4.3'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3
shrinking /nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3/bin/icecast
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3/bin
patching script interpreter paths in /nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3
checking for references to /build in /nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3...
/nix/store/wv6nm3p4lsbwr4xiixrwgxkykkh5cwdg-libvorbis-1.3.5
/nix/store/h12ms7rv1x1vsp20r216yfy78d4ghw7w-icecast-2.4.3
There was a problem hiding this comment.
Failure for system: x86_64-darwin
Package ‘alsa-lib-1.1.5’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/os-specific/linux/alsa-lib/default.nix:32 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
There was a problem hiding this comment.
Success for system: x86_64-darwin
/nix/store/6pghh4kmy1nif140mbiy2ijqs7c76xxi-libtheora-1.1.1
/nix/store/6xcl7fxja4yq5xkbsalbrmifjyjp1ac3-speex-1.2rc2
/nix/store/bxsp838d85fa90kyiyp1c6drrrdw24mn-icecast-2.4.3
/nix/store/si30ksp1fda7sjviwhfh1skfi8z1kpy4-libvorbis-1.3.5
copying path '/nix/store/si30ksp1fda7sjviwhfh1skfi8z1kpy4-libvorbis-1.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/6pghh4kmy1nif140mbiy2ijqs7c76xxi-libtheora-1.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/6xcl7fxja4yq5xkbsalbrmifjyjp1ac3-speex-1.2rc2' from 'https://cache.nixos.org'...
copying path '/nix/store/bxsp838d85fa90kyiyp1c6drrrdw24mn-icecast-2.4.3' from 'https://cache.nixos.org'...
/nix/store/si30ksp1fda7sjviwhfh1skfi8z1kpy4-libvorbis-1.3.5
/nix/store/bxsp838d85fa90kyiyp1c6drrrdw24mn-icecast-2.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Tested a few applications using libvorbis and ogg works fine in all the tested ones.