Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngx_pagespeed, psol: 1.11.33.4 -> 1.13.35.1 #33658

Merged
merged 1 commit into from Jan 10, 2018
Merged

ngx_pagespeed, psol: 1.11.33.4 -> 1.13.35.1 #33658

merged 1 commit into from Jan 10, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 9, 2018

Fixes build when used with nginxMainline.

(FWIW, 1.11.33.4 is from 2016-09-15)

Motivation for this change

Fix ngx_pagespeed when used with nginxMainline.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @3noch

I haven't tested this on an actual server yet, just ran into the build failure and thought I'd fix it.
Looks like enabling requires non-trivial (and possibly Nix-unfriendly) configuration, don't think I'll be using it in the near future.

@dtzWill
ngx_pagespeed, psol: 1.11.33.4 -> 1.13.35.1
be2e01f 
Fixes build when used with nginxMainline.

(FWIW, 1.11.33.4 is from 2016-09-15)
@3noch
Copy link
Contributor

3noch commented Jan 9, 2018

Thanks for doing this.

@adisbladis adisbladis merged commit 6790674 into NixOS:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @3noch @adisbladis @GrahamcOfBorg