Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-rerunfailures: 2.0.1 -> 4.0 #33659

Merged
merged 1 commit into from Jan 10, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jan 9, 2018

Motivation for this change

When nixos-unstable moved forward today I've noticed that tmuxp stopped building because pytest-rerunfailures don't build. Then I've found out that they have done a bunch of releases since it was updated the last time.

So, before the update. It doesn't build. But it does after.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -3394,14 +3394,14 @@ in {
pytest-rerunfailures = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated 👍

@etu etu force-pushed the update-pytest-rerunfailures branch from 39d0b03 to c7eadc3 Compare January 9, 2018 18:26
@adisbladis adisbladis merged commit f9e47ab into NixOS:master Jan 10, 2018
@etu etu deleted the update-pytest-rerunfailures branch January 11, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants